Worn spell dmg stacking?

[Alulien]

I'm noticing some issues with spell damage foci and worn effects stacking. I'm testing on my Mage (Feydakin) with Comet Strike Rk. I (Fire-based).

True Fire (80% to Fire-based) doesn't stack with Brilliance of Fear (15% worn v1 spell dmg) or Brilliance of the Elder (10% worn v1 spell dmg - for redundancy sake). If I unequip my foci and leave a Brilliance item on I receive the listed % increase. I always assumed they stacked since True Fire puts the bonus in slot 1 and the Brilliances are slot 12... or have I been wrong all along and this is working as intended?

Faerune II (5% worn v2 spell dmg) doesn't work for spell dmg at all. With all worn dmg/foci items unequipped spell damage is exactly the same with/without Faerune II item. Edit: It seems like it also doesn't affect melee dmg as a quick test with my Rogue (Daggar) shows 1566 max hit (white hit spam) with his mainhand with/without his Faerune II equipped.

[Vaion]

Investigated this today and this is what I found:

True Fire (80% to Fire-based) doesn't stack with Brilliance of Fear (15% worn v1 spell dmg) or Brilliance of the Elder (10% worn v1 spell dmg - for redundancy sake). If I unequip my foci and leave a Brilliance item on I receive the listed % increase. I always assumed they stacked since True Fire puts the bonus in slot 1 and the Brilliances are slot 12... or have I been wrong all along and this is working as intended?

1) Focus effects have never stacked even if the spell has the same effects in different slots (True Fire uses Slot 1 for Spell Dmg and Brilliance of Fear uses slot 12). The way the focus coding works (and worked previously -- I went and checked in old code just to be 100% sure) is that that the highest focus effect for the focus is used. Some restrictions are made (element resist, specific spells, npc type, etc) but with these two focuses they are both able to apply to Comet Strike Rk. I thus meaning that the highest % of the two is used (True fire at 80% vs Brilliance of Fear at 15%).

To help combat this with the two items that did have Brilliance of Fear as focus effects, I moved them to worn effects instead (See #2). So they will now stack. (Withered Totem of Widdershins & Zombie Flesh Bracer are the two items)

Faerune II (5% worn v2 spell dmg) doesn't work for spell dmg at all. With all worn dmg/foci items unequipped spell damage is exactly the same with/without Faerune II item. Edit: It seems like it also doesn't affect melee dmg as a quick test with my Rogue (Daggar) shows 1566 max hit (white hit spam) with his mainhand with/without his Faerune II equipped.

2) There was a new setting in the code that limited worn effects from stacking with focus effects. Our old code did this automatically, so as soon as I turned on the new rule Faerune II started working properly.

[Alulien]

Thanks for such a thorough review, V!

I wasn't sure if the focus should have been stacking or not, so thanks for clearing that up for me. Let me see if I understand the change that's coming, using the above example: True Fire will stack with either Brilliance of Fear or Faerune II (as worn effects) based on whichever has the higher %?

[Vaion]

True fire will stack with both.

True Fire uses Spell Damage V1 (Focus)
Brilliance of Fear uses Spell Damage V1 (Worn)
Faerune II/III uses Spell Damage V2 (Worn)


Focuses do not stack if they are the same (V1/V1).
Worn Focuses do not stack if they are the same (V1/v1)

Focus and Worn will stack if they are the same (V1/V1)
Focus and Worn will stack if they are not the same (V1/V2)

So with that logic:
True Fire (Focus -V1) will stack with Brillaince of Fear (Worn -V1) and Faerune II+ (Worn - V2)

Hope that makes sense lol

[Alulien]

Makes perfect sense! I misread your comment and missed the differentiation in the v1 and v2s. Thanks!

[rasjaziz]

Thanks for working on this, Vaion. After today's reboot I did some testing and I'm not seeing any difference in melee or spell damage when I have my Faerune III items on or off. Max hits and spell hits are exactly the same, which leads me to believe that the fix didn't happen.

Either that or I'm missing something?

[Nilbus]

Quick and dirty tests in guild hall with my monk. Took off his two faerune items and parsed for 2 mins on vlar, then added 1, 2 mins, added other, 2 mins. All buffs constant.

Fight 1 - no Faerune
min hit - 37
max hit - 17906
Average Hit 1454
DPS - 7003

Fight 2 - Faerune II from HoH helm
min hit - 64
max hit - 14388
Avg hit - 1586
DPS - 7681

Fight 3 - Faerune III from donor legs
min hit - 64
max hit - 17906
Avg hit - 1597
DPs - 7932

[Vaion]

Hmm did you guys check spell damage? I'm afraid I did not check melee damage when I made the fix as I assumed it would fall in line when the spell aspect was fixed.
Let me know if the spell damage is working or not.

[Nilbus]

Did a test with a wizard, faerune is increasing spell damage. Hard to judge with partial resists, but minimum was higher than the base of the nuke dmg with no focus items and faerune 2 and 3.

[rasjaziz]

Like Nilbus said, it appears to be affecting minimum damage (can't tell about avg damage). It is not affecting max hits, though. Not sure if that is intended or not.