Page 1 of 3
Disappearing Achievments
Posted: Mon Dec 07, 2009 4:44 pm
by Milein
I had my 1.5 epic and Dain kill achievements poof on Mil... has this sort of thing happened to anyone else? =/
Re: Disappearing Achievments
Posted: Mon Dec 07, 2009 8:50 pm
by Topsy
I think i know why the 1.5 coulda stopped existing. but not sure of dain. I'm guessing you started your 2.0?
if so i need to change the way its looked at.
Re: Disappearing Achievments
Posted: Mon Dec 07, 2009 9:09 pm
by Koeril
Just a small inquiry, you were in the xp group during the Dain fight? Only that group gets kill credit.
Re: Disappearing Achievments
Posted: Mon Dec 07, 2009 11:22 pm
by Milein
Pretty sure i was but not sure and yeah we started 2.0 last night
Re: Disappearing Achievments
Posted: Tue Dec 08, 2009 1:58 am
by Topsy
Ok then i need to change 1.5 from having a check for true, to checkign for a >=. because of the way lillu wrote the quest_globals. give me some time i can at least make sure you get credit for your 1.5. and i'll see if you got the kill for dain.
Re: Disappearing Achievments
Posted: Tue Dec 08, 2009 2:08 am
by Milein
Topsy wrote:Ok then i need to change 1.5 from having a check for true, to checkign for a >=. because of the way lillu wrote the quest_globals. give me some time i can at least make sure you get credit for your 1.5. and i'll see if you got the kill for dain.
You don't have to worry about Dain, even if i was in xp group for him we'll kill him again before too long lol but i would like my 1.5 achievement back hehe.
Thank you for the hard work!

Re: Disappearing Achievments
Posted: Tue Dec 08, 2009 8:51 am
by Koeril
It'd be good to test the achievement in a controlled environment (ie. I didn't have it, I was in the xp group when I killed him, it does/not work). Not many people have the achievement at all, but I did see that Jeido has it and I figured if he was ever online when Dain needed to die, Jeido would tank it and KS with his group

Re: Disappearing Achievments
Posted: Tue Dec 08, 2009 9:55 am
by Lillu
the problem with these Dain type of achievements is that I can only check if a player is killed him via
sub EVENT_KILLED_MERIT {. Thats basically triggered for the group who got the exp. If there would be a way, who did hit the mob during the fight.. well would be a solution, besides it would trivalize the achievement to hit that mob only once, then done..
Ultimate solution is to use flags, but Dain unfortunately gives no flag yet.
So what we can do atm, is manage the exp groups, at least for Dain. Let's say these kind of achievements aren't for the kill, but for good group management.

Re: Disappearing Achievments
Posted: Tue Dec 08, 2009 1:02 pm
by Milein
What i was thinking is if players have done 15-20k dmg worth of dps to a mob and said mob subsequently dies they get flagged for a kill for achievements/headhunters etc (only on raid mobs however where that kind of dmg is easy for most classes especially with procs but kill credit is usually lacking) but that would even be iffy and likely hard to code

Anyway like i said i don't care much about Dain lol whether i did or did not actually get him, now that we know we can kill him i'll get it soon lol. 1.5 achievement loss however concerns me lol
Re: Disappearing Achievments
Posted: Tue Dec 08, 2009 6:11 pm
by Topsy
Milein,
After looking at the db I see that you do have your 1.5 and i believe i've patched it so it will show up (waiting on lillu to update the script). As for the Dain kill, you did not get the kill credit for that one so it shouldn't be showing up
