Page 1 of 2

Can not manually eat food

Posted: Mon Nov 07, 2011 6:30 pm
by Pigdog
I used to be able to manually eat food to save myself from eating my better stat food. I can no longer do that I get the standard you are too full message and a red text message of Error: the item effect can not be used at this time.

Re: Can not manually eat food

Posted: Mon Nov 07, 2011 11:05 pm
by BloodyMutt
If I recall, whatever food is first in your bags gets eaten first. I may be mistaken.

Re: Can not manually eat food

Posted: Mon Nov 07, 2011 11:35 pm
by Vaion
It's an easy fix. Will get addressed in a few days as I can get to it :)

Re: Can not manually eat food

Posted: Mon Nov 07, 2011 11:53 pm
by Pigdog
BloodyMutt wrote:If I recall, whatever food is first in your bags gets eaten first. I may be mistaken.



No BloodyMutt. Not that my character cannot through out the day automatically eat food in my bags without me doing anything. Its that I cannot manually go "cleek" with my mouse and eat food. I have done this for several years now. I keep not good stat food in my inventory to click and eat from time to time. It helps my good stat food last a long time.

Re: Can not manually eat food

Posted: Tue Nov 08, 2011 12:02 am
by BloodyMutt
I know what you're talking about as I am having the same issue. I was giving you a temporary fix til they figured out what was up. To the best of my knowledge whichever food/water was in the first inventory slot is what gets eaten/drank first.

Re: Can not manually eat food

Posted: Tue Nov 08, 2011 1:54 am
by Micah
BloodyMutt wrote:I know what you're talking about as I am having the same issue. I was giving you a temporary fix til they figured out what was up. To the best of my knowledge whichever food/water was in the first inventory slot is what gets eaten/drank first.


You are correct, the closest food/drink to the "top" of the inventory is used first. So what I do is swap them when I am exp/raiding and swap it back when I am just running around. Then I can chose which food/drink I am using.

Re: Can not manually eat food

Posted: Tue Nov 08, 2011 4:16 am
by BloodyMutt
Thought so, haven't played since '06 or so, memory a little rusty hehe. Look forward to the fix though as I tend to eat food as I loot it in the alt-p >.>;

Re: Can not manually eat food

Posted: Tue Nov 08, 2011 9:00 am
by Trevius
This issue should only occur on SoF+ clients. I am sure it is due to the most recent update I made on the SVN to resolve some other issues with clicky items. Since food does not have an actual click effect on it, I think the fix should be pretty quick and simple. I will look into it a bit and should be able to have a working patch in place for it by tomorrow morning as long as I have time.

The error message doesn't really need to be there, but I added it in to make it easier to identify issues like this from the change. Once all of the possible issues with it are worked out, we can remove the error so it doesn't show up when doing stuff like spamming a mana stone or other instant click item.

It is probably as simple as changing this:

Code: Select all

   spell_id = item->Click.Effect;

   if
   (
      !IsValidSpell(spell_id) ||
      casting_spell_id ||
      delaytimer ||
      spellend_timer.Enabled() ||
      IsStunned() ||
      IsFeared() ||
      IsMezzed() ||
      DivineAura() ||
      (IsSilenced() && !IsDiscipline(spell_id)) ||
      (IsAmnesiad() && IsDiscipline(spell_id)) ||
      (IsDetrimentalSpell(spell_id) && !zone->CanDoCombat())
   )
   {
      Message(13, "Error: the item effect can not be used at this time");
      return;
   }


To this:

Code: Select all

   spell_id = item->Click.Effect;

   if
   (
      spell_id > 0 &&
      (
         !IsValidSpell(spell_id) ||
         casting_spell_id ||
         delaytimer ||
         spellend_timer.Enabled() ||
         IsStunned() ||
         IsFeared() ||
         IsMezzed() ||
         DivineAura() ||
         (IsSilenced() && !IsDiscipline(spell_id)) ||
         (IsAmnesiad() && IsDiscipline(spell_id)) ||
         (IsDetrimentalSpell(spell_id) && !zone->CanDoCombat())
      )
   )
   {
      Message(13, "Error: the item effect can not be used at this time");
      return;
   }


That is untested, but I think it should work. Just need to actually verify it fixes the food issue and still allows the extra checks to work for items that do have click effects on them.

Re: Can not manually eat food

Posted: Tue Nov 08, 2011 3:34 pm
by Vaion
Thanks Trev,

Had to go a little different with the code to prevent the error message. Sent you an email with the fixes =)


And this is fixed with the next code update.

Re: Can not manually eat food

Posted: Tue Nov 08, 2011 5:19 pm
by ChaosSlayer
too bad SOE never improved the way how food is handled in EQ1, after they added a much better way to handle food in EQ2: you get stat bonuses from a food AFTER you eat it (not while it just sits in your bag). Which made a lot more sense...