Post#4 » Sat Sep 04, 2021 9:10 pm
The Enchanter one is on the to do list, that's a bug that possibly got introduced with the last eqemu code merge.
I don't know why the bard donator is melee only, can't see any major reason why we can't add 10% spell damage as well. We can add more detailed descriptions for the effect types in magelo though, it's also a bit confusing in the code as well. I wondered if this was discussed previously on the forums but this is the first feedback since 2011 when there was confusion over whether it was a group or ae buff.
The wizard staff - you're not wrong that the description is a bit misleading, looking at the code the v3 spell damage is custom and I don't know what the history behind it is but it adds the % increase to the base damage after the crit damage is already calculated and then adds the 2 together, so you get the 400% to base damage but overall it doesn't work out as 400%.
If you don't get a crit, then you should see the 400% more clearly, and if you get a crippling blast then it will be 3x on top of the 400% as well so those are as described (I think, this is just me looking at the code, I could be missing something). So it seems to just be criticals where it's added up differently. Is that a bug? I don't know like I say maybe there were reasons for that. I feel like it should add the crit damage on to the spell v3 damage as that just makes more sense, but may mean that we tone it down a bit if it's op after that. Would also need to check other items with spell damage bonus too and see if things need balancing if it's changed.