Resonance on Shadow Fang Necklace

[Shin Noir]

Seems this effect doesn't work. Or if it does, the hailing of our custom NPC maxes your skill anyways making it useless.

I tested it by doing this:
Bard 1.5 epic (+22 modifier, no AA singing masteries yet), using Bellow of Chaos song on Vlan the dummy:
281 damage each time I test consistantly.
Cast renonance on myself via clickie, cast Bellow again:
281 damage each time consistantly.
click off resonance, cast Amplification (a singing mod boost song):
334 damage each time consistantly.
put on resonance + cast amplification:
334 damage each time consistantly.

Conclusion: Resonance clickie doesn't work.

Relevance/Importance? Not a ton, just noting.
Suggested Change? For now it still is a good stat item. If you intended this to have a nice clickie, I guess we can figure something out.

Another finding: Talking to Tremmo and saying "bard" after being a lvl 70 maxxed out bard lowers your instrument skills down to 200, the cap is actually 235 for bards @ lvl 70. (Well maybe more than 235, will tell you when I remaster my skills haha)

[drawnir]

resonance and harmonize (the improvement to resonance on the shadowsong cloak) are confirmed as not working. I think it's been mentioned on the EQMU boards, but fixing these are on the back burner I think. (ref: http://www.eqemulator.net/forums/showthread.php?t=29034)

At 70, instrument caps should be maxed at 310. (ref: http://forums.theconcerthall.net/viewto ... ument+caps). I honestly just came across that post, but it seems that it has ALL our skill caps...pretty handy! hope it helps.

[Tyler]

Striiiaaatttt!

We need a new rule for hard caps on bard instruments. And the harmonize,resonance issue

[Shin Noir]

pssst:
line 1520 of /common/MaxSkill.cpp

Code: Select all

      case BRASS_INSTRUMENTS:
      case SINGING:
      case STRINGED_INSTRUMENTS:
      case WIND_INSTRUMENTS:
      case PERCUSSION_INSTRUMENTS:{
         switch(eqclass){
            case BARD: case BARDGM:{
               r_value = ((level*5) + 5);
               if (level < 5 && skillid == PERCUSSION_INSTRUMENTS){
                  r_value = 0;
               }
               if (level < 8 && skillid == STRINGED_INSTRUMENTS){
                  r_value = 0;
               }
               if (level < 11 && skillid == BRASS_INSTRUMENTS){
                  r_value = 0;
               }
               if (level < 14 && skillid == WIND_INSTRUMENTS){
                  r_value = 0;
               }
               if (r_value > 235)
                  r_value = 235;
               break;
            }
            default: {
               r_value = 0;
            }
            break;
         }// Class Switch
         break;
      } // bard song skills

That last if (r_value > 235) r_value = 235; caps us at 235 for max skill, though modifiers are calculated later, if it is truly 310 at lvl 70 then probably need to consider fixing this as Tyler said..

[striat]

MaxSkills has not been used for obtain spell caps for several years. Caps are stored in the database. The only relevance of that file may be training with a GM. It also may be fully deprecated.

Skill caps are set appropriately though. Can't say the same for the bard skill npc.