Token Exchange

General issues.
User avatar
Belvino
Posts: 218

Re: Token Exchange

Post#91 » Fri Jan 25, 2019 9:16 pm

Also if you need Testing let me know I'm going to save my tokens for a while.

Ydiss
Posts: 1193

Re: Token Exchange

Post#92 » Sat Jan 26, 2019 12:04 am

Belvino wrote:Thanks guys. I had forgotten this was changed till I killed Luclin this past weekend and was like "What is this Mushroom Guy" Then found this info. I will add I'm not seeing Tokens on the vender. Not sure if that's a known issue.

Not sure, this was once an issue if I recall. Will look into it asap.

That said, I've found the cause of the dupe items on the prize list problem and fixed it :) It was indeed as I had thought, something wrong with the function that checks if a client has an item or not.

I managed to recreate the problem and that helped me find the cause; it failed when items were in certain bank slots. Believe it or not, the plugin the server uses to check for an item on a player is very old. Titanium old. The plugin must not have been updated and so was only checking for bank slots (and bags within those slots) up to slot 16. Of course, we now have up to 24 slots. That's potentially 80 total slots the plugin was missing.

So, if you had an item in those slots, all of the tokens (not just the Xeru one) will have thought you didn't have that item and merilly added it to the prize list.

I've updated the plugin on test (should be live now). I just tested it 80 times (using the bank slots from 17 to 24 to store the items I got)... I got 77 useable items from DSK, not one duplicated (and 2 holiday items and one rare artefact...).

Happy to say it's working now :) This is likely to have fixed other scripts that used that plugin, too.

Will have a look at the vendor. Can anyone else confirm the vendor isn't selling anything?

Ydiss
Posts: 1193

Re: Token Exchange

Post#93 » Sat Jan 26, 2019 12:31 am

Which zone is the spirited merchant not creating any tokens?

User avatar
Belvino
Posts: 218

Re: Token Exchange

Post#94 » Sat Jan 26, 2019 1:31 am

Vex Thal

User avatar
Belvino
Posts: 218

Re: Token Exchange

Post#95 » Sat Jan 26, 2019 1:43 am

Thanks for the Quick fix Awesome Job.

Ydiss
Posts: 1193

Re: Token Exchange

Post#96 » Sat Jan 26, 2019 3:00 am

Belvino wrote:Vex Thal

Reading the thread again, it looks like this was an issue since at least September and hasn't yet been addressed.

I've got a suspicion what's causing it. Will try to have a look this weekend.

Ydiss
Posts: 1193

Re: Token Exchange

Post#97 » Sat Jan 26, 2019 10:59 am

Morning!

Jumped on this morning (after two coffees, of course) and had a look at the the issue with the merchant in Vex Thal. So it's fixed. Tested it on test and it works perfectly now.

Will post the changes live later today (no reboot required). After that, please go ahead and try it out and let me know if you still have any issues.

Incidentally, yay me for my first Luclin "kill" :lol:

Ydiss
Posts: 1193

Re: Token Exchange

Post#98 » Sat Jan 26, 2019 7:32 pm

The above fix is now live.

User avatar
ocsi
Posts: 180

Re: Token Exchange

Post#99 » Sat Jan 26, 2019 10:05 pm

The merchant is now selling tokens. Thanks Ydiss :)
Your friendly neighborhood gnome,

Eschew.

User avatar
Belvino
Posts: 218

Re: Token Exchange

Post#100 » Sun Jan 27, 2019 8:11 pm

Confirmed Selling Tokens for me as well.

Return to “General”

Who is online

Users browsing this forum: No registered users and 1 guest